fix(py): filename sanitization, conn guard, retry clamp, set for hard_skips#39
Merged
Neo23x0 merged 1 commit intoNextronSystems:script-robustnessfrom Mar 17, 2026
Conversation
… retry, use set for hard_skips - Filename sanitization: also replace backslashes and NUL bytes in Content-Disposition header to prevent header injection - Connection close: initialize conn=None before try block so the finally block doesn't hit NameError if _make_connection raises - Retry-After: clamp to 0-300s with max(0, min(...)) instead of separate negative check - hard_skips: use a set for O(1) membership checks instead of O(n) list scan in the mount-point dedup loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes in the Python 3 collector, found by Axiom-Loop review:
conn = Nonebefore try block preventsNameErrorin finally if_make_connectionraisesmax(0, min(int(val), 300))replaces separate negative check; cleaner and handles edge cases